Skip to content

[release-4.4] Bug 1847197: Tolerate all taints#179

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
Miciah:cherry-pick-171-to-release-4.4
Jul 24, 2020
Merged

[release-4.4] Bug 1847197: Tolerate all taints#179
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
Miciah:cherry-pick-171-to-release-4.4

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Jun 15, 2020 •
edited
Loading

Configure the operand daemonset to tolerate all taints in order to accommodate user-set taints.

This PR reverts #140.

  • assets/dns/daemonset.yaml: Tolerate all taints.
  • pkg/manifests/bindata.go: Regenerate.

This is a manual cherry-pick of #171.

@ddreggors @Miciah
Tolerate all taints
be33c7a 
Configure the operand daemonset to tolerate all taints in order to
accommodate user-set taints.

This commit reverts 3eb10d0.

This commit fixes bug 1847197.

https://bugzilla.redhat.com/show_bug.cgi?id=1847197

* assets/dns/daemonset.yaml: Tolerate all taints.
* pkg/manifests/bindata.go: Regenerate.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 15, 2020

@Miciah: This pull request references Bugzilla bug 1847197, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1813479 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1813479 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

Bug 1847197: Tolerate all taints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 15, 2020
@Miciah Miciah changed the title Bug 1847197: Tolerate all taints [release-4.4] Bug 1847197: Tolerate all taints Jun 15, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 25, 2020

@Miciah: This pull request references Bugzilla bug 1847197, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1813479 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1813479 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

[release-4.4] Bug 1847197: Tolerate all taints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link
Contributor

danehans commented Jul 23, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit 122ed90 into openshift:release-4.4 Jul 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2020

@Miciah: All pull requests linked via external trackers have merged: openshift/cluster-dns-operator#179. Bugzilla bug 1847197 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1847197: Tolerate all taints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans Awaiting requested review from danehans

@frobware frobware Awaiting requested review from frobware

Assignees

@danehans danehans

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Miciah @openshift-ci-robot @danehans @sdodson @openshift-merge-robot @ddreggors